Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the minimum version for using autoscaling/v2 api to 1.23 #3155

Merged
merged 3 commits into from
Jul 17, 2023
Merged

Change the minimum version for using autoscaling/v2 api to 1.23 #3155

merged 3 commits into from
Jul 17, 2023

Conversation

jlawrienyt
Copy link

@jlawrienyt jlawrienyt commented Jul 13, 2023 •
edited
Loading

This addresses issue #3154

Checklist

  • Changelog updated or skip changelog label added

@jlawrienyt jlawrienyt requested a review from a team as a code owner July 13, 2023 15:04
@sumo-drosiek
Copy link
Contributor

Why is it needed if the issue is with k8s 1.26. Why current template does not work as expected?

@swiatekm
Copy link

From the issue, it sounds like you run into trouble if you have the Chart installed on a lower version (and therefore are using the deprecated api group), and then upgrade to 1.26, where that api group was removed. Kubernetes itself has no issue with this, and in fact will internally convert to the latest supported api group, but Helm itself won't, and reports an issue with the existing manifests - even if the upgrade would, in fact, fix the problem.

@sumo-drosiek
Copy link
Contributor

From the issue, it sounds like you run into trouble if you have the Chart installed on a lower version (and therefore are using the deprecated api group), and then upgrade to 1.26, where that api group was removed. Kubernetes itself has no issue with this, and in fact will internally convert to the latest supported api group, but Helm itself won't, and reports an issue with the existing manifests - even if the upgrade would, in fact, fix the problem.

Then it's better to check for 1.23, so the issue won't be a problem if he first installation has been done on at least 1.23

@jlawrie @sumo-drosiek
Update .changelog/3155.fixed.txt
c72aa61 
Co-authored-by: Dominik Rosiek <58699848+sumo-drosiek@users.noreply.github.com>
@swiatekm
Copy link

From the issue, it sounds like you run into trouble if you have the Chart installed on a lower version (and therefore are using the deprecated api group), and then upgrade to 1.26, where that api group was removed. Kubernetes itself has no issue with this, and in fact will internally convert to the latest supported api group, but Helm itself won't, and reports an issue with the existing manifests - even if the upgrade would, in fact, fix the problem.

Then it's better to check for 1.23, so the issue won't be a problem if he first installation has been done on at least 1.23

That's what this PR does, right?

@sumo-drosiek sumo-drosiek merged commit 98640d5 into SumoLogic:main Jul 17, 2023
@jlawrienyt jlawrienyt deleted the use-stable-hpa-api-version-with-k8s-1.23 branch July 18, 2023 13:44
@montmanu montmanu mentioned this pull request Oct 6, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jlawrienyt @sumo-drosiek @swiatekm @jlawrie